New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to go1.8.3 #33387

Merged
merged 1 commit into from May 31, 2017

Conversation

Projects
None yet
6 participants
@cpuguy83
Contributor

cpuguy83 commented May 25, 2017

Note that go1.8.2 contains a security fix (CVE-2017-8932).

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann May 26, 2017

Contributor

When we bump the go version, it sometimes causes files that were go fmt-compliant to no longer pass the check. But we don't run the check until those files change, and it ends up being confusing.

Is it possible to check the formatting of all files at the time we upgrade go? Ideally this would be automated, but a manual pass would work for now.

I doubt it's an issue for this patch release of go, but it's probably still worth checking.

Contributor

aaronlehmann commented May 26, 2017

When we bump the go version, it sometimes causes files that were go fmt-compliant to no longer pass the check. But we don't run the check until those files change, and it ends up being confusing.

Is it possible to check the formatting of all files at the time we upgrade go? Ideally this would be automated, but a manual pass would work for now.

I doubt it's an issue for this patch release of go, but it's probably still worth checking.

@thaJeztah thaJeztah referenced this pull request May 29, 2017

Closed

17.06.0 RC2 tracker #2

23 of 23 tasks complete
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 29, 2017

Member

ARM failing on;

16:37:36 ----------------------------------------------------------------------
16:37:36 FAIL: docker_cli_logs_test.go:215: DockerSuite.TestLogsFollowSlowStdoutConsumer
16:37:36 
16:37:36 docker_cli_logs_test.go:244:
16:37:36     c.Assert(actual, checker.Equals, expected)
16:37:36 ... obtained int = 169954
16:37:36 ... expected int = 200000
16:37:36 
16:37:41 

Used to be a flaky test, but not sure why it's failing again. I'll restart ARM

Member

thaJeztah commented May 29, 2017

ARM failing on;

16:37:36 ----------------------------------------------------------------------
16:37:36 FAIL: docker_cli_logs_test.go:215: DockerSuite.TestLogsFollowSlowStdoutConsumer
16:37:36 
16:37:36 docker_cli_logs_test.go:244:
16:37:36     c.Assert(actual, checker.Equals, expected)
16:37:36 ... obtained int = 169954
16:37:36 ... expected int = 200000
16:37:36 
16:37:41 

Used to be a flaky test, but not sure why it's failing again. I'll restart ARM

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 May 29, 2017

Contributor

It always fails on PR's.

Contributor

cpuguy83 commented May 29, 2017

It always fails on PR's.

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 29, 2017

Member

I see there's a couple of locations that are still on Go 1.7.5, for example: contrib/builder/deb/aarch64/debian-jessie/Dockerfile#L15, and man/Dockerfile#L1

And even 1.7.4; contrib/builder/rpm/armhf/centos-7/Dockerfile#L12

Member

thaJeztah commented May 29, 2017

I see there's a couple of locations that are still on Go 1.7.5, for example: contrib/builder/deb/aarch64/debian-jessie/Dockerfile#L15, and man/Dockerfile#L1

And even 1.7.4; contrib/builder/rpm/armhf/centos-7/Dockerfile#L12

Bump go to go1.8.3
Note that go1.8.2 contains a security fix (CVE-2017-8932).

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 May 30, 2017

Contributor

Updated.

Contributor

cpuguy83 commented May 30, 2017

Updated.

@thaJeztah

LGTM

@tiborvass

This comment has been minimized.

Show comment
Hide comment
@tiborvass

tiborvass May 31, 2017

Collaborator

LGTM

Collaborator

tiborvass commented May 31, 2017

LGTM

@tonistiigi

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah May 31, 2017

Member

ARM failure is #33387 (comment), I'll go ahead and merge this one

Member

thaJeztah commented May 31, 2017

ARM failure is #33387 (comment), I'll go ahead and merge this one

@thaJeztah thaJeztah merged commit 75e685d into moby:master May 31, 2017

6 of 7 checks passed

arm Jenkins build Docker-PRs-arm 410 has failed
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 34553 has succeeded
Details
janky Jenkins build Docker-PRs 43151 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 3542 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 14430 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3264 has succeeded
Details

@andrewhsu andrewhsu referenced this pull request May 31, 2017

Merged

Update GO_VERSION to 1.8.3 #8

@mlaventure mlaventure referenced this pull request May 31, 2017

Merged

Bump go to go1.8.3 #9

@StefanScherer StefanScherer referenced this pull request Jun 9, 2017

Merged

Update golang 1.8.3 #173

@cpuguy83 cpuguy83 deleted the cpuguy83:go1.8.3 branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment