New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the same log filename to logging plugins on start/stop requests #33583

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
4 participants
@naag
Contributor

naag commented Jun 8, 2017

Signed-off-by: Peter Bücker peter.buecker@gmail.com

- What I did

Provide a solution for #33569.

- How I did it

The /LogDriver.StopLogging request needs additional context (basePath) to provide the correct filename to the logging plugin. This context was added since I found no way to retrieve it from existing data structures at hand.

- How to verify it

Rerun the steps given at #33569.

- Description for the changelog

Pass the same log filename to logging plugins on start/stop requests.

Logging driver should receive same file in start/stop request
Signed-off-by: Peter Bücker <peter.buecker@gmail.com>

@thaJeztah thaJeztah requested a review from cpuguy83 Jun 8, 2017

@thaJeztah thaJeztah added this to the 17.06.0 milestone Jun 8, 2017

@andrewhsu andrewhsu referenced this pull request Jun 8, 2017

Closed

17.06.0 RC3 tracker #8

40 of 40 tasks complete
@cpuguy83

LGTM

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit d053bde into moby:master Jun 8, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 34832 has succeeded
Details
janky Jenkins build Docker-PRs 43432 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 3805 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 14721 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3544 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 8, 2017

Member

Thanks @naag ! Congratulations with your first contribution 🎉

Member

thaJeztah commented Jun 8, 2017

Thanks @naag ! Congratulations with your first contribution 🎉

@naag

This comment has been minimized.

Show comment
Hide comment
@naag

naag Jun 8, 2017

Contributor

Thanks @cpuguy83 and @thaJeztah!

Contributor

naag commented Jun 8, 2017

Thanks @cpuguy83 and @thaJeztah!

@naag naag deleted the naag:33569-logging-plugin-file-inconsistency branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment