New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: Remove daemon datastructure dump functionality #33598

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
5 participants
@aaronlehmann
Contributor

aaronlehmann commented Jun 8, 2017

When sending SIGUSR1 to the daemon, it can crash because of a concurrent map access panic, showing a stack trace involving dumpDaemon. It appears it's not possible to recover from a concurrent map access panic (see https://gist.github.com/aaronlehmann/281681d458e30e1d9b4637952f22793a for a demonstration). Since it's important that SIGUSR1 not be a destructive operation, sadly the best course of action I can think of is to remove this functionality.

cc @jhowardmsft @cpuguy83

daemon: Remove daemon datastructure dump functionality
When sending SIGUSR1 to the daemon, it can crash because of a concurrent
map access panic, showing a stack trace involving dumpDaemon. It appears
it's not possible to recover from a concurrent map access panic. Since
it's important that SIGUSR1 not be a destructive operation, sadly the
best course of action I can think of is to remove this functionality.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

@aaronlehmann aaronlehmann referenced this pull request Jun 8, 2017

Closed

17.06.0 RC3 tracker #8

40 of 40 tasks complete
@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Jun 8, 2017

Contributor

Huh. That really sucks as I've found this invaluable. LGTM 😢

Contributor

jhowardmsft commented Jun 8, 2017

Huh. That really sucks as I've found this invaluable. LGTM 😢

@thaJeztah

LGTM (unfortunately)

@cpuguy83

LGTM

@cpuguy83 cpuguy83 merged commit 252e610 into moby:master Jun 9, 2017

5 of 6 checks passed

windowsRS1 Jenkins build Docker-PRs-WoW-RS1 14748 has failed
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 34859 has succeeded
Details
janky Jenkins build Docker-PRs 43460 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 3834 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3571 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment