New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable legacy (v1) registries by default #33629

Merged
merged 2 commits into from Jun 12, 2017

Conversation

Projects
None yet
4 participants
@thaJeztah
Member

thaJeztah commented Jun 11, 2017

Deprecation of interacting with v1 registries was started in docker 1.8.3, which added a --disable-legacy-registry flag.

This option was announced to be the default starting with docker 17.06, and v1 registries completely removed in docker 17.12.

This patch updates the default, and disables interaction with v1 registres by default.

ping @dmcgowan @aaronlehmann

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 11, 2017

Member

Found some tests that need updating;

  • DockerRegistryAuthHtpasswdSuite.TestLogoutWithExternalAuth looks to depend on v1 registry fallback as well
  • DockerRegistryAuthHtpasswdSuite.TestPullNoCredentialsNotFound needs to be updated, because it uses fallback to v1 registries
Member

thaJeztah commented Jun 11, 2017

Found some tests that need updating;

  • DockerRegistryAuthHtpasswdSuite.TestLogoutWithExternalAuth looks to depend on v1 registry fallback as well
  • DockerRegistryAuthHtpasswdSuite.TestPullNoCredentialsNotFound needs to be updated, because it uses fallback to v1 registries

thaJeztah added some commits Jun 11, 2017

Disable legacy (v1) registries by default
Deprecation of interacting with v1 registries was
started in docker 1.8.3, which added a `--disable-legacy-registry`
flag.

This option was anounced to be the default starting
with docker 17.06, and v1 registries completely
removed in docker 17.12.

This patch updates the default, and disables
interaction with v1 registres by default.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update docs, completion scripts for disable-legacy-registry
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jun 12, 2017

Member

Tests were updated; all green now

Member

thaJeztah commented Jun 12, 2017

Tests were updated; all green now

@mlaventure

LGTM

@aaronlehmann

This comment has been minimized.

Show comment
Hide comment
@aaronlehmann

aaronlehmann Jun 12, 2017

Contributor

LGTM

Not sure about doing this after the freeze, but not I'm not going to block this.

Contributor

aaronlehmann commented Jun 12, 2017

LGTM

Not sure about doing this after the freeze, but not I'm not going to block this.

@mlaventure mlaventure merged commit df33013 into moby:master Jun 12, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 34928 has succeeded
Details
janky Jenkins build Docker-PRs 43529 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 3905 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 14827 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3641 has succeeded
Details

@thaJeztah thaJeztah deleted the thaJeztah:disable-v1-registry-by-default branch Jun 12, 2017

@aaronlehmann aaronlehmann referenced this pull request Jun 16, 2017

Merged

Add manifest command #138

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment