New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: Improve store locking #33755

Merged
merged 1 commit into from Jun 21, 2017

Conversation

Projects
None yet
5 participants
@aaronlehmann
Contributor

aaronlehmann commented Jun 21, 2017

This showed up in a recent profile.

Search doesn't need to take a lock on the store, because digestset has
its own locking.

Some other methods can get by with a read lock instead of an exclusive
lock.

cc @cpuguy83 @tonistiigi @dmcgowan

image: Improve store locking
This showed up in a recent profile.

Search doesn't need to take a lock on the store, because digestset has
its own locking.

Some other methods can get by with a read lock instead of an exclusive
lock.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Jun 21, 2017

Member

LGTM

Member

tonistiigi commented Jun 21, 2017

LGTM

@cpuguy83

LGTM

@cpuguy83 cpuguy83 merged commit e64c2d7 into moby:master Jun 21, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 35177 has succeeded
Details
janky Jenkins build Docker-PRs 43786 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 4147 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15083 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3874 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment