New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: Dedicated scratch space for service VM utilities #33809

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@jhowardmsft
Contributor

jhowardmsft commented Jun 23, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Adds a dedicated space for the service VM utilities to use as a scratch space.

@johnstep PTAL.
@gupta-ak FYI

@jhowardmsft jhowardmsft changed the title from LCOW: Dedicate scratch space for service VM utilities to LCOW: Dedicated scratch space for service VM utilities Jun 24, 2017

@johnstep

LGTM

Show outdated Hide outdated daemon/graphdriver/lcow/lcow.go Outdated
Show outdated Hide outdated daemon/graphdriver/lcow/lcow.go Outdated
LCOW: Dedicated scratch space for global service VM
Signed-off-by: John Howard <jhoward@microsoft.com>
@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Jun 27, 2017

Contributor

Rebased on master.

Contributor

jhowardmsft commented Jun 27, 2017

Rebased on master.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Jun 28, 2017

Contributor

Green finally. Power CI must have run a dozen times - very flaky at the moment 😢

Contributor

jhowardmsft commented Jun 28, 2017

Green finally. Power CI must have run a dozen times - very flaky at the moment 😢

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Jun 28, 2017

Contributor

@thaJeztah @vdemeester PTAL if you have time. Thanks 😄

Contributor

jhowardmsft commented Jun 28, 2017

@thaJeztah @vdemeester PTAL if you have time. Thanks 😄

@thaJeztah

LGTM

scratchAttached := false
if _, err := os.Stat(d.svmScratchSpaceFile); err == nil {
// We have a scratch space already, so just attach it as a mapped virtual disk
logrus.Debugf("lcowdriver: startuvm: (%s) attaching pre-existing scratch", context)

This comment has been minimized.

@thaJeztah

thaJeztah Jun 28, 2017

Member

not introduced by this PR, but context is a confusing name (as it's not a context)

@thaJeztah

thaJeztah Jun 28, 2017

Member

not introduced by this PR, but context is a confusing name (as it's not a context)

@thaJeztah thaJeztah merged commit 8b29ba5 into moby:master Jun 28, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 35328 has succeeded
Details
janky Jenkins build Docker-PRs 43938 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 4314 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15277 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4026 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/svmdedicatedscratch branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment