New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stderr logging for journald and syslog #33832

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@glasser
Contributor

glasser commented Jun 26, 2017

logger.PutMessage, added in #28762 (v17.04.0-ce), clears msg.Source. So journald
and syslog were treating stderr messages as if they were stdout.

Signed-off-by: David Glasser glasser@davidglasser.net

Fixes #33834

Fix stderr logging for journald and syslog
logger.PutMessage, added in #28762 (v17.04.0-ce), clears msg.Source. So journald
and syslog were treating stderr messages as if they were stdout.

Signed-off-by: David Glasser <glasser@davidglasser.net>
@cpuguy83

LGTM, thanks!

@LK4D4

LK4D4 approved these changes Jun 26, 2017

LGTM

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Jun 27, 2017

Contributor

Well, CI is being funky from issues with GH yesterday, and it doesn't really test logging drivers anyway.
Merging since this looks good.

Contributor

cpuguy83 commented Jun 27, 2017

Well, CI is being funky from issues with GH yesterday, and it doesn't really test logging drivers anyway.
Merging since this looks good.

@cpuguy83 cpuguy83 merged commit 7843bfd into moby:master Jun 27, 2017

3 of 6 checks passed

experimental Jenkins build Docker-PRs-experimental 35295 is running
Details
janky Jenkins build Docker-PRs 43906 is running
Details
powerpc Jenkins build Docker-PRs-powerpc 4271 is running
Details
dco-signed All commits are signed
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15245 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3995 has succeeded
Details

@glasser glasser deleted the glasser:glasser/msg-source branch Jun 27, 2017

@thaJeztah thaJeztah referenced this pull request Nov 12, 2017

Closed

SIGSEGV in syslog driver #159

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment