New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: Change directory from lcow to "Linux Containers" #33835

Merged
merged 2 commits into from Jun 27, 2017

Conversation

Projects
None yet
4 participants
@jhowardmsft
Contributor

jhowardmsft commented Jun 27, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Updates the default kernel/initrd location from pf\lcow to pf\Linux Containers. Don't ask.

@johnstep

jhowardmsft added some commits Jun 27, 2017

Vendor github.com/jhowardmsft/opengcs v0.0.7
Signed-off-by: John Howard <jhoward@microsoft.com>
LCOW: Change to c:\Program Files\Linux Containers
Signed-off-by: John Howard <jhoward@microsoft.com>
@johnstep

LGTM

@@ -299,7 +299,7 @@ func (clnt *client) createLinux(containerID string, checkpoint string, checkpoin
Owner: defaultOwner,
TerminateOnLastHandleClosed: true,
HvRuntime: &hcsshim.HvRuntime{
ImagePath: `c:\program files\lcow`,
ImagePath: `c:\Program Files\Linux Containers`,

This comment has been minimized.

@johnstep

johnstep Jun 27, 2017

Contributor

Why does this use a hard-coded c:\Program Files instead of the ProgramFiles environment variable? Also, why not export this name from OpenGCS?

Nit: With changing to mixed case, I would capitalize the drive letter too.

@johnstep

johnstep Jun 27, 2017

Contributor

Why does this use a hard-coded c:\Program Files instead of the ProgramFiles environment variable? Also, why not export this name from OpenGCS?

Nit: With changing to mixed case, I would capitalize the drive letter too.

This comment has been minimized.

@jhowardmsft

jhowardmsft Jun 27, 2017

Contributor

Yeah, all this is going to go away shortly anyway, but I will address in a follow-up. The change of directory name is the important bit for now.

@jhowardmsft

jhowardmsft Jun 27, 2017

Contributor

Yeah, all this is going to go away shortly anyway, but I will address in a follow-up. The change of directory name is the important bit for now.

@vdemeester

LGTM 👼

@vdemeester vdemeester merged commit 359ed99 into moby:master Jun 27, 2017

7 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 35301 has succeeded
Details
janky Jenkins build Docker-PRs 43910 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 4274 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 3560 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 15249 has succeeded
Details
z Jenkins build Docker-PRs-s390x 3998 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/changedir branch Jun 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment