New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: Remove hard-coding #34398

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
5 participants
@jhowardmsft
Contributor

jhowardmsft commented Aug 3, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Removes the next // TODO @jhowardmsft LCOW Support... Uses the options rather than hard-coding.

@johnstep PTAL.

LCOW: Remove hard-coding
Signed-off-by: John Howard <jhoward@microsoft.com>
@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 3, 2017

Contributor

@darrenstahlmsft FYI. This is the one that will conflict with the options-removal-for-OCI. Could you review this quickly as well though.

Contributor

jhowardmsft commented Aug 3, 2017

@darrenstahlmsft FYI. This is the one that will conflict with the options-removal-for-OCI. Could you review this quickly as well though.

@johnstep

LGTM

@darstahl

darstahl approved these changes Aug 4, 2017 edited

LGTM (not a maintainer)

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 5, 2017

Contributor

ping @mlaventure @thaJeztah @vdemeester Been reviewed ^^. Any chance one of you can do a once over and merge/comment?

Contributor

jhowardmsft commented Aug 5, 2017

ping @mlaventure @thaJeztah @vdemeester Been reviewed ^^. Any chance one of you can do a once over and merge/comment?

@mlaventure

LGTM

@mlaventure mlaventure merged commit 537f8c1 into moby:master Aug 7, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36087 has succeeded
Details
janky Jenkins build Docker-PRs 44707 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5089 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 16097 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4821 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/libcontainerd branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment