New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: Additional flags for VHD boot #34451

Merged
merged 1 commit into from Aug 24, 2017

Conversation

Projects
None yet
5 participants
@jhowardmsft
Contributor

jhowardmsft commented Aug 8, 2017

Signed-off-by: John Howard jhoward@microsoft.com

@johnstep Turns out two additional flags are needed for VHD boot in the HCS call.

LCOW: Additional flags for VHD boot
Signed-off-by: John Howard <jhoward@microsoft.com>
@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 8, 2017

Contributor

FYI, the matching change in opengcs launching service VMs is at https://github.com/moby/moby/pull/34450/files#diff-7bdf53950d8ddc78663fd947d862d820R244

Contributor

jhowardmsft commented Aug 8, 2017

FYI, the matching change in opengcs launching service VMs is at https://github.com/moby/moby/pull/34450/files#diff-7bdf53950d8ddc78663fd947d862d820R244

@johnstep

LGTM

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 15, 2017

Contributor

@thaJeztah Can we get this merged? We're in a half-way state between opengcs and the daemon where VHD boot almost works, but it needs this matching PR merged. Thanks :)

Contributor

jhowardmsft commented Aug 15, 2017

@thaJeztah Can we get this merged? We're in a half-way state between opengcs and the daemon where VHD boot almost works, but it needs this matching PR merged. Thanks :)

@yongtang

Code LGTM

@yongtang yongtang merged commit e5cdaf1 into moby:master Aug 24, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36187 has succeeded
Details
janky Jenkins build Docker-PRs 44805 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5191 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 16203 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4933 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/bootvhdx branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment