New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: Force Hyper-V Isolation #34468

Merged
merged 1 commit into from Aug 27, 2017

Conversation

Projects
None yet
7 participants
@jhowardmsft
Contributor

jhowardmsft commented Aug 9, 2017

Signed-off-by: John Howard jhoward@microsoft.com

@johnstep Forces LCOW containers to be Hyper-V isolation, and errors out if user explicitly tries to start one with process isolation. If you have a VERY recent build, this will also enable pause/resume of Linux containers.

@jstarks FYI.

@johnstep

LGTM

Show outdated Hide outdated daemon/create_windows.go
LCOW: Force to be Hyper-V Isolation
Signed-off-by: John Howard <jhoward@microsoft.com>
@johnstep

LGTM

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 9, 2017

Contributor

@darrenstahlmsft PTAL. May need similar in containerd too.

Contributor

jhowardmsft commented Aug 9, 2017

@darrenstahlmsft PTAL. May need similar in containerd too.

@darstahl

This comment has been minimized.

Show comment
Hide comment
@darstahl

darstahl Aug 10, 2017

Contributor

LGTM (not a maintainer). Only question is are we sure we want to error when a user requests process isolation rather than just warn and force Hyper-V isolation?

Contributor

darstahl commented Aug 10, 2017

LGTM (not a maintainer). Only question is are we sure we want to error when a user requests process isolation rather than just warn and force Hyper-V isolation?

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 10, 2017

Contributor

Only question is are we sure we want to error when a user requests process isolation rather than just warn and force Hyper-V isolation?

I did consider that but decided that if the user is requesting a specific invalid action, then that is an error. As opposed to second-guessing them.

Contributor

jhowardmsft commented Aug 10, 2017

Only question is are we sure we want to error when a user requests process isolation rather than just warn and force Hyper-V isolation?

I did consider that but decided that if the user is requesting a specific invalid action, then that is an error. As opposed to second-guessing them.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 15, 2017

Contributor

@thaJeztah PTAL.

Contributor

jhowardmsft commented Aug 15, 2017

@thaJeztah PTAL.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Aug 27, 2017

Contributor

ping @thaJeztah ....

Contributor

jhowardmsft commented Aug 27, 2017

ping @thaJeztah ....

@yongtang

Code LGTM.

@yongtang yongtang merged commit a63a2e8 into moby:master Aug 27, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36216 has succeeded
Details
janky Jenkins build Docker-PRs 44835 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5221 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 16237 has succeeded
Details
z Jenkins build Docker-PRs-s390x 4974 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment