Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Enabling ILB/ELB on windows using per-node, per-network LB endpoint. #34674
Note: This is 1 of 3 PRs (the other 2 are in libnetwork and swarmkit repos).
Signed-off-by: Pradip Dhara firstname.lastname@example.org
- What I did
- How I did it
- How to verify it
- Description for the changelog
Please sign your commits following these rules:
$ git clone -b "windows_routingmesh" email@example.com:pradipd/moby.git somewhere $ cd somewhere $ git rebase -i HEAD~842354127368 editor opens change each 'pick' to 'edit' save the file and quit $ git commit --amend -s --no-edit $ git rebase --continue # and repeat the amend for each commit $ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
@vieux : Can you help me understand the integration tests?
So, I moved the test to docker_api_swarm_test.go, but the test is exactly the same. That fixed the Janky error, but, I don't think that was the proper way to fix the test.
I also tried to add the test to integration/service, but, I can't figure out how to run the tests.
thaJeztah left a comment
thanks for addressing my nits; don't forget to squash commits to two commits; 1 for "vendoring" and 1 for the local changes. (We don't have to preserve the "fix vendor" and "address review comments" when merging)