New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCOW: VHDX boot to readonly. #34754

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@jhowardmsft
Contributor

jhowardmsft commented Sep 6, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Fixes internal VSO bug 12969254. Makes the VHDX boot read-only to avoid file sharing violation running 2nd container. @beweedon, @jstarks @PatrickLang FYI.

@johnstep PTAL.

jhowardmsft added some commits Sep 6, 2017

LCOW: VHDX boot to read-only
Signed-off-by: John Howard <jhoward@microsoft.com>
Revendor Microsoft/opengcs @v0.3.3
Signed-off-by: John Howard <jhoward@microsoft.com>
@johnstep

LGTM

@yongtang

I think the PR makes sense. LGTM if Jenkins passes.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Sep 12, 2017

Contributor

Jenkins & GH are out-of-sync. RS1 completed successfully here: https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/16941/console

OK to merge? (Although restarted in the hope it will re-sync successfully)

Contributor

jhowardmsft commented Sep 12, 2017

Jenkins & GH are out-of-sync. RS1 completed successfully here: https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/16941/console

OK to merge? (Although restarted in the hope it will re-sync successfully)

@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Sep 12, 2017

Member

All test passes now. Thanks! 👍

Member

yongtang commented Sep 12, 2017

All test passes now. Thanks! 👍

@yongtang yongtang merged commit 969b76d into moby:master Sep 12, 2017

7 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36765 has succeeded
Details
janky Jenkins build Docker-PRs 45404 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5804 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 3763 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 16943 has succeeded
Details
z Jenkins build Docker-PRs-s390x 5586 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/read-only branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment