New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --enable-api-cors flag #34821

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
5 participants
@thaJeztah
Member

thaJeztah commented Sep 12, 2017

The --enable-api-cors flag was deprecated in f3dd2db,
and marked for removal in docker 17.09 through 85f92ef.

This patch removes the deprecated flag.

- Description for the changelog

Remove deprecated --enable-api-cors daemon flag

Remove deprecated --enable-api-cors flag
The `--enable-api-cors` flag was deprecated in f3dd2db,
and marked for removal in docker 17.09 through 85f92ef.

This patch removes the deprecated flag.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@boaz1337

👍

@vdemeester

LGTM 🦁
/cc @tiborvass

@yongtang

LGTM 👍

@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Sep 12, 2017

Member

The Jenkins build for windowsRS1 has been stuck in "being scheduled" state. Adding rebuild/windowsRS1 label will not trigger a rerun. I think it may need to have a reset for Jenkins to pick up?

Member

yongtang commented Sep 12, 2017

The Jenkins build for windowsRS1 has been stuck in "being scheduled" state. Adding rebuild/windowsRS1 label will not trigger a rerun. I think it may need to have a reset for Jenkins to pick up?

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 13, 2017

Member

Only failure on Windows is

02:51:10 ...     "Stderr:   no matching manifest for windows/amd64 in the manifest list entries\n"

Which is being addressed by #34829 - should we merge this one?

Member

thaJeztah commented Sep 13, 2017

Only failure on Windows is

02:51:10 ...     "Stderr:   no matching manifest for windows/amd64 in the manifest list entries\n"

Which is being addressed by #34829 - should we merge this one?

@yongtang

This comment has been minimized.

Show comment
Hide comment
@yongtang

yongtang Sep 14, 2017

Member

All tests passed now 👍

Member

yongtang commented Sep 14, 2017

All tests passed now 👍

@yongtang yongtang merged commit dc35a8a into moby:master Sep 14, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36766 has succeeded
Details
janky Jenkins build Docker-PRs 45405 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5805 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17057 has succeeded
Details
z Jenkins build Docker-PRs-s390x 5585 has succeeded
Details

@thaJeztah thaJeztah deleted the thaJeztah:remove-enable-api-cors branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment