New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable shadowing causing LayersSize to be reported as 0 #34826

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
7 participants
@cezarsa
Contributor

cezarsa commented Sep 12, 2017

- What I did

Fix variable shadowing causing LayersSize to be reported as 0 in /system/df (docker system df) calls.

- How I did it

This is a simple one-line fix removing duplicated declaration of allLayersSize.

- Description for the changelog
Fix layers size reported as 0 in docker system df.

Fix variable shadowing causing LayersSize to be reported as 0
Signed-off-by: Cezar Sa Espinola <cezarsa@gmail.com>
@thaJeztah

LGTM

looks like this was introduced in 3aa4a00

ping @mlaventure @jhowardmsft

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 12, 2017

Member

Thanks for spotting this one!

Member

thaJeztah commented Sep 12, 2017

Thanks for spotting this one!

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Sep 12, 2017

Contributor

LGTM. Good catch!

Contributor

jhowardmsft commented Sep 12, 2017

LGTM. Good catch!

@mlaventure

This comment has been minimized.

Show comment
Hide comment
@mlaventure

mlaventure Sep 12, 2017

Contributor

LGTM

Contributor

mlaventure commented Sep 12, 2017

LGTM

@yongtang yongtang merged commit 84144a8 into moby:master Sep 12, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 36771 has succeeded
Details
janky Jenkins build Docker-PRs 45410 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 5811 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 16964 has succeeded
Details
z Jenkins build Docker-PRs-s390x 5591 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment