New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"docker swarm init --force-new-cluster" use limit #34881

Merged
merged 1 commit into from Sep 27, 2017

Conversation

Projects
None yet
4 participants
@ityangchen
Contributor

ityangchen commented Sep 18, 2017

Signed-off-by: yangchenliang yangchenliang@huawei.com

When worker executes docker swarm init --force-new-cluster,docker would hang.So only manager can process it.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Show outdated Hide outdated daemon/cluster/swarm.go Outdated
"docker swarm init --force-new-cluster" use limit
Signed-off-by: yangchenliang <yangchenliang@huawei.com>

When worker executor `docker swarm init
--force-new-cluster`,docker would hang.So only manager can process it.

Signed-off-by: yangchenliang <yangchenliang@huawei.com>
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 26, 2017

Member

@aaronlehmann looks like the PR was updated

Member

thaJeztah commented Sep 26, 2017

@aaronlehmann looks like the PR was updated

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit 0b968f9 into moby:master Sep 27, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37076 has succeeded
Details
janky Jenkins build Docker-PRs 45747 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6119 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17310 has succeeded
Details
z Jenkins build Docker-PRs-s390x 5919 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment