New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version comparison when negotiating the the API version #35008

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@yujuhong
Contributor

yujuhong commented Sep 28, 2017

- What I did
Fix version comparison when negotiating the the API version.

- How I did it

- How to verify it
Unit test.

- Description for the changelog

Fix version comparison when negotiating the the API version.

- A picture of a cute animal (not mandatory but encouraged)

@yujuhong yujuhong requested a review from dnephin as a code owner Sep 28, 2017

@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Sep 28, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "cli-version" git@github.com:yujuhong/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Sep 28, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "cli-version" git@github.com:yujuhong/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Fix version comparison when negotiating the the API version
Signed-off-by: Yu-Ju Hong <yjhong@google.com>

@GordonTheTurtle GordonTheTurtle removed the dco/no label Sep 28, 2017

@yujuhong

This comment has been minimized.

Show comment
Hide comment
@yujuhong

yujuhong Sep 28, 2017

Contributor

The original behavior was introduced in #33888. /cc @thaJeztah

Contributor

yujuhong commented Sep 28, 2017

The original behavior was introduced in #33888. /cc @thaJeztah

@dnephin

LGTM

I think this is correct

@yongtang

LGTM

@yongtang yongtang merged commit 14ce1f1 into moby:master Sep 28, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37143 has succeeded
Details
janky Jenkins build Docker-PRs 45825 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6200 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17377 has succeeded
Details
z Jenkins build Docker-PRs-s390x 5991 has succeeded
Details
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Sep 29, 2017

Member

oh! looks like this is the same as #34511, but completely forgot about that one 😞

Member

thaJeztah commented Sep 29, 2017

oh! looks like this is the same as #34511, but completely forgot about that one 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment