New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use windows console mode constants from Azure/go-ansiterm #35056

Merged
merged 2 commits into from Oct 4, 2017

Conversation

Projects
None yet
6 participants
@tklauser
Contributor

tklauser commented Oct 2, 2017

- What I did

Re-vendor github.com/Azure/go-ansiterm in order get the newly added console mode constants and use them in pkg/term instead of the local copies.

- How I did it

Get the constants into go-ansiterm via Azure/go-ansiterm#23, re-vendor into moby/moby and manually replace the constants in moby's pkg/term.

- How to verify it

All tests still pass.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

image

tklauser added some commits Oct 2, 2017

vendor: re-vendor github.com/Azure/go-ansiterm
Re-vendor go-ansiterm to d6e3b3328b783f23731bc4d058875b0371ff8109 in
order to get the newly added console mode constants.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Use all console mode constants from go-ansiterm
The missing console mode constants were added to go-ansiterm in
Azure/go-ansiterm#23. Use these constants instead of defining them
locally.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

@tklauser tklauser changed the title from Win console mode consts to Use windows console mode constants from Azure/go-ansiterm Oct 2, 2017

@vdemeester vdemeester requested review from johnstep and jhowardmsft Oct 2, 2017

@thaJeztah

LGTM

ping @jstarks

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Oct 4, 2017

Contributor

LGTM

Contributor

jhowardmsft commented Oct 4, 2017

LGTM

@jstarks

This comment has been minimized.

Show comment
Hide comment
@jstarks

jstarks Oct 4, 2017

Contributor

LGTM

Contributor

jstarks commented Oct 4, 2017

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Oct 4, 2017

Member

Thanks! It's all green, so merging 👍

Member

thaJeztah commented Oct 4, 2017

Thanks! It's all green, so merging 👍

@thaJeztah thaJeztah merged commit 1c4fad8 into moby:master Oct 4, 2017

7 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37190 has succeeded
Details
janky Jenkins build Docker-PRs 45867 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6249 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 3845 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17428 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6083 has succeeded
Details

@tklauser tklauser deleted the tklauser:win-console-mode-consts branch Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment