Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Windows Daemon should respect DOCKER_TMPDIR #35077
- What I did
- How I did it
- How to verify it
- Description for the changelog
hcsshim uses Golang's built in tmpdir utilities, which create a tmp dir at the env TMP location during layer extraction. This doesn't currently respect Moby's tmpdir settings.
This would also fix any other dependencies using Golang's built in tmpdir utilities.
Note that Golang will not attempt to create TMP if it does not exist (layer extraction will fail in this case). We might want to add a check here to either bail out if TMP doesn't exist, create it, or not set TMP if DOCKER_TMPDIR does not exist.
Oct 20, 2017
6 checks passed
referenced this pull request
Dec 20, 2017
We need to get this into a new EE release. Azure VMs are deploying with a 30GB C:, but 100GB D: . Many customers are putting DOCKER_ROOT on d: because there is more space available, its faster & cheaper. d: is local SSD storage so its perfect for non-persistent container storage