New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop filtering Windows manifest lists by version #35117

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
5 participants
@johnstep
Contributor

johnstep commented Oct 7, 2017

Signed-off-by: John Stephens johnstep@docker.com

Stop excluding incompatible Windows versions because it is possible to run some with Hyper-V isolation. However, still move compatible versions to the top, since they are preferred, but preserve the order if no compatible versions are found. More work is required to finalize the policy; for example, versions greater than the host should probably be excluded, even if just the UBR (Update Build Release) is higher.

Stop filtering Windows manifest lists by version
Signed-off-by: John Stephens <johnstep@docker.com>
@jhowardmsft

LGTM from code inspection. I’ll try to find time to verify this evening or tomorrow.

@StefanScherer StefanScherer referenced this pull request Oct 9, 2017

Merged

Add manifest command #138

1 of 1 task complete
@dmcgowan

LGTM

@jhowardmsft jhowardmsft merged commit 9ed0922 into moby:master Oct 10, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37263 has succeeded
Details
janky Jenkins build Docker-PRs 45943 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6330 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17508 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6129 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment