New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't abort when setting may_detach_mounts #35172

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
4 participants
@cpuguy83
Contributor

cpuguy83 commented Oct 11, 2017

83c2152 sets the kernel param for
fs.may_detach_mounts, but this is not necessary for the daemon to
operate. Instead of erroring out (and thus aborting startup) just log
the error.

Fixes docker/for-linux#126

Don't abort when setting may_detach_mounts
83c2152 sets the kernel param for
fs.may_detach_mounts, but this is not neccessary for the daemon to
operate. Instead of erroring out (and thus aborting startup) just log
the error.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@thaJeztah

LGTM

@yongtang

LGTM

@thaJeztah thaJeztah merged commit 02a2ba3 into moby:master Oct 11, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37358 has succeeded
Details
janky Jenkins build Docker-PRs 46041 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6430 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17613 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6237 has succeeded
Details

@cpuguy83 cpuguy83 deleted the cpuguy83:for_linux_126_dont_abort branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment