Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Increase container default shutdown timeout on Windows #35184
The shutdown timeout for containers in insufficient on Windows. If the daemon is shutting down, and a container takes longer than expected to shut down, this can cause the container to remain in a bad state after restart, and never be able to start again. Increasing the timeout makes this less likely to occur.
This helps reduce the likelihood of #29392 happening while waiting for containerd 1.0 integration, which changes the model here enough that the real fix will be in containerd.
Signed-off-by: Darren Stahl firstname.lastname@example.org
referenced this pull request
Oct 12, 2017
Looks like some CI tests are checking that the logs contain the shutdown time specified in the config.
The log message they look for was never correct, as it just read from the config, while there is a more complicated shutdown time computation used for the actual shutdown timeout. I've changed the log from:
(Assuming a 3 second configured shutdown timeout, and a calculated actual shutdown timeout of 15 seconds due to a 10 second container shutdown timeout and a 5 second shutdown grace period)
I haven't looked at docs yet, will do soon