New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix startup logging #35253

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@jhowardmsft
Contributor

jhowardmsft commented Oct 19, 2017

Signed-off-by: John Howard jhoward@microsoft.com

This has been annoying me for ages. Finally putting a fix in.

Startup debug logging before this change:

...
DEBU[2017-10-19T11:01:22.116355100-07:00] Stackdump - waiting signal at %!s(*uint16=0xc0423a2940)
...
INFO[2017-10-19T11:01:24.307247800-07:00] API listen on //./pipe/docker_engine
DEBU[2017-10-19T11:01:24.307247800-07:00] Config reload - waiting signal at %!s(*uint16=0xc042c02000)

And after

...
DEBU[2017-10-19T11:08:25.636352700-07:00] Stackdump - waiting signal at Global\docker-daemon-2696
...
INFO[2017-10-19T11:08:27.653351000-07:00] API listen on //./pipe/docker_engine
DEBU[2017-10-19T11:08:27.653351000-07:00] Config reload - waiting signal at Global\docker-daemon-config-2696

@thaJeztah @johnstep PTAL

Fix startup logging
Signed-off-by: John Howard <jhoward@microsoft.com>
@thaJeztah

LGTM, thanks!

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Oct 23, 2017

ping @vdemeester PTAL

@vdemeester

LGTM 🐮

@vdemeester vdemeester merged commit 2058854 into moby:master Oct 23, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37451 has succeeded
Details
janky Jenkins build Docker-PRs 46142 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6543 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17722 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6336 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment