New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes LCOW after containerd 1.0 introduced regressions #35320

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
6 participants
@jhowardmsft
Contributor

jhowardmsft commented Oct 27, 2017

Signed-off-by: John Howard jhoward@microsoft.com

@mlaventure @johnstep PTAL (would be good to get this merged ASAP).

Fixes #35302

#34895 regressed LCOW functionality. Two small spot fixes in this PR. Verified locally.

Fixes LCOW after containerd 1.0 introduced regressions
Signed-off-by: John Howard <jhoward@microsoft.com>
@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Oct 27, 2017

Member

If there were regressions I guess LCOW is missing test coverage. This should probably include some unit tests.

Member

dnephin commented Oct 27, 2017

If there were regressions I guess LCOW is missing test coverage. This should probably include some unit tests.

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Oct 27, 2017

Contributor

@dnephin This needs end to end CI on RS3 which is being worked on.

Contributor

jhowardmsft commented Oct 27, 2017

@dnephin This needs end to end CI on RS3 which is being worked on.

@dnephin

This comment has been minimized.

Show comment
Hide comment
@dnephin

dnephin Oct 27, 2017

Member

end-to-end tests are not a substitute for unit tests.

Member

dnephin commented Oct 27, 2017

end-to-end tests are not a substitute for unit tests.

@johnstep

LGTM

@jhowardmsft

This comment has been minimized.

Show comment
Hide comment
@jhowardmsft

jhowardmsft Oct 27, 2017

Contributor

@dnephin I'm not saying they are, but unit tests are going to be a way off yet while the feature still has so many pieces not complete.

Contributor

jhowardmsft commented Oct 27, 2017

@dnephin I'm not saying they are, but unit tests are going to be a way off yet while the feature still has so many pieces not complete.

@mlaventure

LGTM

@mlaventure mlaventure merged commit 2613c3d into moby:master Oct 27, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37537 has succeeded
Details
janky Jenkins build Docker-PRs 46231 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6642 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17810 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6433 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/lcow-set-oci-root branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment