New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: fix long stream sync #35404

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
5 participants
@tonistiigi
Member

tonistiigi commented Nov 3, 2017

fixes #35391

The 5 second timeout should only count for the time it takes to connect to the session, not for the actual transfer.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi tonistiigi requested a review from dnephin as a code owner Nov 3, 2017

@dnephin

dnephin approved these changes Nov 3, 2017

LGTM,

just a naming nit

Show outdated Hide outdated builder/dockerfile/builder.go
builder: fix long stream sync
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@delissonjunio

This comment has been minimized.

Show comment
Hide comment
@delissonjunio

delissonjunio Nov 3, 2017

Sorry, I'm not really familiar with Docker's development timeline yet - when exactly can I get to try the fix out? I would really like to be working with this as soon as possible

delissonjunio commented Nov 3, 2017

Sorry, I'm not really familiar with Docker's development timeline yet - when exactly can I get to try the fix out? I would really like to be working with this as soon as possible

@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Nov 3, 2017

Member

@delissonjunio After it gets merged, depending on what priority is assigned to the issue it may get backported to affected releases. If not, it will end up either in 17.11 or 17.12 /cc @thaJeztah

Member

tonistiigi commented Nov 3, 2017

@delissonjunio After it gets merged, depending on what priority is assigned to the issue it may get backported to affected releases. If not, it will end up either in 17.11 or 17.12 /cc @thaJeztah

@thaJeztah

LGTM

@thaJeztah thaJeztah merged commit 2c1043c into moby:master Nov 4, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37710 has succeeded
Details
janky Jenkins build Docker-PRs 46414 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6823 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 17979 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6632 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment