New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing lock in ProcessEvent #35516

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
4 participants
@mlaventure
Contributor

mlaventure commented Nov 16, 2017

Signed-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com

- What I did

  • Add a missing lock.
  • Take a lock a bit earlier

- How I did it

Updated the code :trollface:

- How to verify it

Moving the lock a bit earlier fixes #35497 99% of the time. For the missing lock, I haven't been able to get a reliable test

- Description for the changelog

🤷‍♂️

- A picture of a cute animal (not mandatory but encouraged)
🐱

Add missing lock in ProcessEvent
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Nov 17, 2017

Member

LGTM. Can we test this?

Member

tonistiigi commented Nov 17, 2017

LGTM. Can we test this?

@mlaventure

This comment has been minimized.

Show comment
Hide comment
@mlaventure

mlaventure Nov 18, 2017

Contributor

The missing lock, like I said in the description, haven't been able to find a sure test.

The race, it'll be tested in docker/cli#696

Contributor

mlaventure commented Nov 18, 2017

The missing lock, like I said in the description, haven't been able to find a sure test.

The race, it'll be tested in docker/cli#696

@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah merged commit 9d00efb into moby:master Nov 30, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37862 has succeeded
Details
janky Jenkins build Docker-PRs 46575 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 6987 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18130 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6790 has succeeded
Details

@thaJeztah thaJeztah removed this from backlog in maintainers-session Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment