New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SubSecondPrecision to config option. #35529

Merged
merged 1 commit into from Dec 5, 2017

Conversation

@dungeonmaster18
Contributor

dungeonmaster18 commented Nov 16, 2017

Fixes issue #35384 .

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Nov 19, 2017

Contributor

Hi, Can anyone please review my PR.

cc @ripcurld0 @thaJeztah

Contributor

dungeonmaster18 commented Nov 19, 2017

Hi, Can anyone please review my PR.

cc @ripcurld0 @thaJeztah

@boaz1337

boaz1337 approved these changes Nov 20, 2017 edited

LGTM 💯
Can you squash your commits into one, though? 😃

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Nov 20, 2017

Contributor

Hey @ripcurld0 done that. 😃 . Anything else you want me change let me know.

Contributor

dungeonmaster18 commented Nov 20, 2017

Hey @ripcurld0 done that. 😃 . Anything else you want me change let me know.

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18
Contributor

dungeonmaster18 commented Nov 27, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Nov 28, 2017

Member

Wondering if this should take a similar approach as --syslog-format to specify the time-format to be used;

screen shot 2017-11-28 at 11 44 50

Member

thaJeztah commented Nov 28, 2017

Wondering if this should take a similar approach as --syslog-format to specify the time-format to be used;

screen shot 2017-11-28 at 11 44 50

@moby moby deleted a comment from GordonTheTurtle Nov 29, 2017

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Nov 30, 2017

Contributor

I haven't given a thought to that @thaJeztah . As the issue was just to add subsecond to fluentd, so I did that. I have to see about this because I am completely new and also a noob. So I will let you know once I have something regarding this.

Contributor

dungeonmaster18 commented Nov 30, 2017

I haven't given a thought to that @thaJeztah . As the issue was just to add subsecond to fluentd, so I did that. I have to see about this because I am completely new and also a noob. So I will let you know once I have something regarding this.

@anusha-ragunathan

This comment has been minimized.

Show comment
Hide comment
@anusha-ragunathan

anusha-ragunathan Nov 30, 2017

Contributor

I'm fine with this change.

Needs doc updates in https://github.com/docker/docker.github.io/blob/8896e88867202a2dda926adadb6a4a350fd10165/engine/admin/logging/fluentd.md#options and auto completion updates for bash and zsh.

Contributor

anusha-ragunathan commented Nov 30, 2017

I'm fine with this change.

Needs doc updates in https://github.com/docker/docker.github.io/blob/8896e88867202a2dda926adadb6a4a350fd10165/engine/admin/logging/fluentd.md#options and auto completion updates for bash and zsh.

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Nov 30, 2017

Contributor

For docs I will create an pull by tomorrow. But I didn't get the auto completion updates for bash and zsh. Can you explain it to me? Thanks!

Contributor

dungeonmaster18 commented Nov 30, 2017

For docs I will create an pull by tomorrow. But I didn't get the auto completion updates for bash and zsh. Can you explain it to me? Thanks!

@anusha-ragunathan

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Nov 30, 2017

Contributor

Sure I will have a look into it and I will try create a PR for that as well by this weekend. Thanks for your time and review. 😄

Contributor

dungeonmaster18 commented Nov 30, 2017

Sure I will have a look into it and I will try create a PR for that as well by this weekend. Thanks for your time and review. 😄

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Dec 1, 2017

Contributor

Hey @anusha-ragunathan . I have added documentation and auto completion command for bash and zsh. Here are those PR:

Contributor

dungeonmaster18 commented Dec 1, 2017

Hey @anusha-ragunathan . I have added documentation and auto completion command for bash and zsh. Here are those PR:

@anusha-ragunathan

This comment has been minimized.

Show comment
Hide comment
@anusha-ragunathan

anusha-ragunathan Dec 1, 2017

Contributor

LGTM

Contributor

anusha-ragunathan commented Dec 1, 2017

LGTM

Show outdated Hide outdated vendor.conf Outdated
Show outdated Hide outdated vendor.conf Outdated
@GordonTheTurtle

This comment has been minimized.

Show comment
Hide comment
@GordonTheTurtle

GordonTheTurtle Dec 5, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "subsecond-precision-config" git@github.com:dungeonmaster18/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle commented Dec 5, 2017

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "subsecond-precision-config" git@github.com:dungeonmaster18/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle removed the dco/no label Dec 5, 2017

Added SubSecondPrecision flag in fluentd logger
Signed-off-by: dungeonmaster18 <umesh4257@gmail.com>
@cpuguy83

LGTM

Would be really awesome if someone could follow-up to add the WriteTimeout support which is new in flutend-golang as well.

@dungeonmaster18

This comment has been minimized.

Show comment
Hide comment
@dungeonmaster18

dungeonmaster18 Dec 5, 2017

Contributor

I will check that @cpuguy83 and I will also ask people behind msgpack and philhofer/fwd to add tags to their package so that we can replace the commit id from vendor.conf. I will create a pull for that once I am done with that.

Contributor

dungeonmaster18 commented Dec 5, 2017

I will check that @cpuguy83 and I will also ask people behind msgpack and philhofer/fwd to add tags to their package so that we can replace the commit id from vendor.conf. I will create a pull for that once I am done with that.

@thaJeztah

LGTM, thanks!

@thaJeztah thaJeztah merged commit 3461289 into moby:master Dec 5, 2017

7 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38220 has succeeded
Details
janky Jenkins build Docker-PRs 46948 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7350 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 4001 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18484 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7159 has succeeded
Details

@dungeonmaster18 dungeonmaster18 deleted the dungeonmaster18:subsecond-precision-config branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment