New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consumes MIME type for NetworkConnect #35542

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
4 participants
@masaeedu
Contributor

masaeedu commented Nov 19, 2017

- What I did
Changed the MIME type of the NetworkConnect route to the correct type.

- How I did it
The route expects application/json instead of application/octet-stream. This can be seen from the schema of the body parameter as well as from actually calling the route (it explodes if sent an application/octet-stream content type header).

- How to verify it
Try calling the route with the old and new MIME types for the Content-Type header. Only the new one will work.

- Description for the changelog

Changed the MIME type of the NetworkConnect route to the correct type.

- A picture of a cute animal (not mandatory but encouraged)
youhavedonemeabetray.jpg

Fix consumes MIME type for NetworkConnect
This route expects `application/json`. Sending a content type header of `application/octet-stream` results in an error.

Signed-off-by: Asad Saeeduddin <masaeedu@gmail.com>
@thaJeztah

LGTM

@yongtang

LGTM

@thaJeztah thaJeztah merged commit 4f4a027 into moby:master Nov 20, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 37920 has succeeded
Details
janky Jenkins build Docker-PRs 46632 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7044 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18190 has succeeded
Details
z Jenkins build Docker-PRs-s390x 6848 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment