New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fix width/height swap #35631

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
6 participants
@jhowardmsft
Contributor

jhowardmsft commented Nov 28, 2017

Signed-off-by: John Howard jhoward@microsoft.com

Fixes #35616

@johnstep PTAL

In the containerd move to 1.0 (commit ddae20c in PR #34895), width/height were inadvertently swapped. The correct calling convention into hcsProcess.ResizeConsole is (w, h).

Previous code was at ddae20c#diff-da772cf2abf2ae03bec24ef9b38f8200L699

Updated code is at ddae20c#diff-1a69c80e50d3f16bc95fc6e8bb3a7254R932 where you can see the parameters have been switched.

@mlaventure FYI

Windows: Fix width/height swap
Signed-off-by: John Howard <jhoward@microsoft.com>
@johnstep

LGTM

@thaJeztah

LGTM 🙃

@yongtang yongtang merged commit 29708da into moby:master Nov 29, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38090 has succeeded
Details
janky Jenkins build Docker-PRs 46784 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7194 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18341 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7015 has succeeded
Details

@jhowardmsft jhowardmsft deleted the Microsoft:jjh/heightwidth branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment