New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential panic during plugin set. #35632

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
4 participants
@anusha-ragunathan
Contributor

anusha-ragunathan commented Nov 28, 2017

Plugin config can have Mounts without a 'Source' field. In such cases,
performing a 'plugin set' on the mount source will panic the daemon. Its
the same case for device paths as well. This detects the case and
returns error.

Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com

Fix potential panic during plugin set.
Plugin config can have Mounts without a 'Source' field. In such cases,
performing a 'plugin set' on the mount source will panic the daemon. Its
the same case for device paths as well. This detects the case and
returns error.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
@vieux

vieux approved these changes Nov 28, 2017

LGTM

@thaJeztah

LGTM

@anusha-ragunathan anusha-ragunathan merged commit f943df7 into moby:master Nov 28, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38071 has succeeded
Details
janky Jenkins build Docker-PRs 46787 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7197 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18344 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7018 has succeeded
Details

@anusha-ragunathan anusha-ragunathan deleted the anusha-ragunathan:fix-panic branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment