New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore error type in FindNetwork #35634

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
6 participants
@fcrisciani
Contributor

fcrisciani commented Nov 29, 2017

- What I did
Restored libnetwork error type

- Description for the changelog

The error type libnetwork.ErrNoSuchNetwork is used in the controller
to retry the network creation as a managed network though the manager.
The change of the type was breaking the logic causing the network to
not being created anymore so that no new container on that network
was able to be launched

Relates to: docker/swarmkit#2388

@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Nov 29, 2017

Contributor

@cpuguy83 PTAL

Contributor

fcrisciani commented Nov 29, 2017

@cpuguy83 PTAL

Show outdated Hide outdated daemon/network.go
@cpuguy83

LGTM

Restore error type in FindNetwork
The error type libnetwork.ErrNoSuchNetwork is used in the controller
to retry the network creation as a managed network though the manager.
The change of the type was breaking the logic causing the network to
not being created anymore so that no new container on that network
was able to be launched
Added unit test

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
@thaJeztah

LGTM

@yongtang yongtang merged commit e0b3ddd into moby:master Nov 30, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38102 has succeeded
Details
janky Jenkins build Docker-PRs 46816 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7224 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18370 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7044 has succeeded
Details
@jmarcos-cano

This comment has been minimized.

Show comment
Hide comment
@jmarcos-cano

jmarcos-cano Jan 9, 2018

quick question guys, which release version contains this fix?

jmarcos-cano commented Jan 9, 2018

quick question guys, which release version contains this fix?

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Jan 9, 2018

Member

This is included in Docker 17.12 (and up), and back-ported to Docker 17.09.1

Member

thaJeztah commented Jan 9, 2018

This is included in Docker 17.12 (and up), and back-ported to Docker 17.09.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment