New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netdb debug tool #35677

Merged
merged 3 commits into from Dec 7, 2017

Conversation

Projects
None yet
5 participants
@fcrisciani
Contributor

fcrisciani commented Dec 1, 2017

- What I did
New daemon config for networking diagnose

-How I tested it
Added a unit test in the reload_test section

- Description for the changelog

Add a new daemon config to enable the diagnose server for the networking layer

The libnetwork vendoring also bring:
Fix for #34515
Fix for watchMiss leak and ipvs deadlock

Netlink revendoring for netlink timeout: vishvananda/netlink@bd6d5de...b2de5d1
Libnetwork revendoring: docker/libnetwork@64ae588...9bca9a4

- A picture of a cute animal (not mandatory but encouraged)
cute-animals-cover

Show outdated Hide outdated vendor.conf
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 2, 2017

Member

libnetwork side; docker/libnetwork#2027

Member

thaJeztah commented Dec 2, 2017

libnetwork side; docker/libnetwork#2027

@fcrisciani

This comment has been minimized.

Show comment
Hide comment
@fcrisciani

fcrisciani Dec 5, 2017

Contributor

Windows CI failed:

19:16:19 ----------------------------------------------------------------------
19:16:19 PANIC: docker_api_logs_test.go:152: DockerSuite.TestLogsAPIUntil
19:16:19 
19:16:19 ... Panic: runtime error: index out of range (PC=0x45AC01)
19:16:19 
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:509
19:16:19   in call32
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/panic.go:491
19:16:19   in gopanic
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/panic.go:28
19:16:19   in panicindex
19:16:19 docker_api_logs_test.go:175
19:16:19   in DockerSuite.TestLogsAPIUntil
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:509
19:16:19   in call32
19:16:19 d:/CI/CI-d8f0b6be0/go/src/reflect/value.go:434
19:16:19   in Value.call
19:16:19 d:/CI/CI-d8f0b6be0/go/src/reflect/value.go:302
19:16:19   in Value.Call
19:16:19 c:/gopath/src/github.com/docker/docker/vendor/github.com/go-check/check/check.go:816
19:16:19   in suiteRunner.forkTest.func1
19:16:19 c:/gopath/src/github.com/docker/docker/vendor/github.com/go-check/check/check.go:672
19:16:19   in suiteRunner.forkCall.func1
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:2337
19:16:19   in goexit
19:16:23 
19:16:23 ----------------------------------------------------------------------
Contributor

fcrisciani commented Dec 5, 2017

Windows CI failed:

19:16:19 ----------------------------------------------------------------------
19:16:19 PANIC: docker_api_logs_test.go:152: DockerSuite.TestLogsAPIUntil
19:16:19 
19:16:19 ... Panic: runtime error: index out of range (PC=0x45AC01)
19:16:19 
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:509
19:16:19   in call32
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/panic.go:491
19:16:19   in gopanic
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/panic.go:28
19:16:19   in panicindex
19:16:19 docker_api_logs_test.go:175
19:16:19   in DockerSuite.TestLogsAPIUntil
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:509
19:16:19   in call32
19:16:19 d:/CI/CI-d8f0b6be0/go/src/reflect/value.go:434
19:16:19   in Value.call
19:16:19 d:/CI/CI-d8f0b6be0/go/src/reflect/value.go:302
19:16:19   in Value.Call
19:16:19 c:/gopath/src/github.com/docker/docker/vendor/github.com/go-check/check/check.go:816
19:16:19   in suiteRunner.forkTest.func1
19:16:19 c:/gopath/src/github.com/docker/docker/vendor/github.com/go-check/check/check.go:672
19:16:19   in suiteRunner.forkCall.func1
19:16:19 d:/CI/CI-d8f0b6be0/go/src/runtime/asm_amd64.s:2337
19:16:19   in goexit
19:16:23 
19:16:23 ----------------------------------------------------------------------
@mavenugo

LGTM

@thaJeztah

Left some comments, but feel free to discuss

Show outdated Hide outdated daemon/reload.go
Show outdated Hide outdated cmd/dockerd/config.go

fcrisciani added some commits Dec 1, 2017

Add option to enable networkDB debug
Add a new configuration option to allow the enabling
of the networkDB debug. The option is only parsed using the
reload event. This will protect the daemon on start or restart
if the option is left behind in the config file

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Vendoring of libnetwork
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Vendoring netlink library
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
@vieux

vieux approved these changes Dec 6, 2017

LGTM

@thaJeztah

LGTM

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 7, 2017

Member

Experimental failure is not related;

22:20:05 ----------------------------------------------------------------------
22:20:05 FAIL: check_test.go:366: DockerSwarmSuite.TearDownTest
22:20:05 
22:20:05 check_test.go:371:
22:20:05     d.Stop(c)
22:20:05 daemon/daemon.go:395:
22:20:05     t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
22:20:05 ... Error: Error while stopping the daemon dcc3900ad90b2 : exit status 130
22:20:05 
22:20:05 
22:20:05 ----------------------------------------------------------------------
22:20:05 PANIC: docker_api_swarm_service_test.go:201: DockerSwarmSuite.TestAPISwarmServicesUpdateStartFirst
22:20:05 
22:20:05 [dcc3900ad90b2] waiting for daemon to start
22:20:05 [dcc3900ad90b2] daemon started
22:20:05 
22:20:05 [dcc3900ad90b2] daemon started
22:20:05 Attempt #2: daemon is still running with pid 10039
22:20:05 Attempt #3: daemon is still running with pid 10039
22:20:05 Attempt #4: daemon is still running with pid 10039
22:20:05 [dcc3900ad90b2] exiting daemon
22:20:05 ... Panic: Fixture has panicked (see related PANIC)
22:20:05 
22:20:05 ----------------------------------------------------------------------
Member

thaJeztah commented Dec 7, 2017

Experimental failure is not related;

22:20:05 ----------------------------------------------------------------------
22:20:05 FAIL: check_test.go:366: DockerSwarmSuite.TearDownTest
22:20:05 
22:20:05 check_test.go:371:
22:20:05     d.Stop(c)
22:20:05 daemon/daemon.go:395:
22:20:05     t.Fatalf("Error while stopping the daemon %s : %v", d.id, err)
22:20:05 ... Error: Error while stopping the daemon dcc3900ad90b2 : exit status 130
22:20:05 
22:20:05 
22:20:05 ----------------------------------------------------------------------
22:20:05 PANIC: docker_api_swarm_service_test.go:201: DockerSwarmSuite.TestAPISwarmServicesUpdateStartFirst
22:20:05 
22:20:05 [dcc3900ad90b2] waiting for daemon to start
22:20:05 [dcc3900ad90b2] daemon started
22:20:05 
22:20:05 [dcc3900ad90b2] daemon started
22:20:05 Attempt #2: daemon is still running with pid 10039
22:20:05 Attempt #3: daemon is still running with pid 10039
22:20:05 Attempt #4: daemon is still running with pid 10039
22:20:05 [dcc3900ad90b2] exiting daemon
22:20:05 ... Panic: Fixture has panicked (see related PANIC)
22:20:05 
22:20:05 ----------------------------------------------------------------------
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 7, 2017

Member

See #33805, #33041 for the failing tests

Member

thaJeztah commented Dec 7, 2017

See #33805, #33041 for the failing tests

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 7, 2017

Member

Merging, after discussion with @vieux since the failures are not related

Member

thaJeztah commented Dec 7, 2017

Merging, after discussion with @vieux since the failures are not related

@thaJeztah thaJeztah merged commit 58dec54 into moby:master Dec 7, 2017

5 of 7 checks passed

experimental Jenkins build Docker-PRs-experimental 38261 has encountered an error
Details
powerpc Jenkins build Docker-PRs-powerpc 7382 has encountered an error
Details
dco-signed All commits are signed
janky Jenkins build Docker-PRs 47003 has succeeded
Details
vendor Jenkins build Docker-PRs-vendor 4015 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18524 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7209 has succeeded
Details

@andres99x andres99x referenced this pull request Jan 18, 2018

Closed

Connection Timeout #36053

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Apr 2, 2018

Member

This also includes docker/libnetwork#1976, which fixes #35261

Member

thaJeztah commented Apr 2, 2018

This also includes docker/libnetwork#1976, which fixes #35261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment