Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix awslogs batch size calculation #35726
- What I did
- How I did it
The added type holds the batching mechanism and the counter used for determining whether or not to submit a batch of log events.
- How to verify it
The change can be verified by using the steps from #35725 to reproduce the issue and then comparing it to a build from this changeset. The appropriate test and test mock have been updated to validate this behavior.
- Description for the changelog
referenced this pull request
Dec 7, 2017
I'm not wild about how you've reorganized the code here. Previously, the code was intended to be ordered such that caller was above callee, or most-abstract to most-concrete. Now you have concrete implementation details (like the
@jahkeup : This patch has code rearrangement that's not necessary, as mentioned in #35726 (comment). Can you update the change such that only the code relevant to the fix is updated? We want to keep the code changes minimal, if and when possible. This also becomes important for considerations for backporting/crossporting to other releases.
I'm still trying to repro the above failures in the integration tests. I do have some failures, but they're different one tests from the ones observed on jenkins and they seem to be happening irregularly. I'll try rebasing to take in any test fixes to see if it makes a difference.
left some suggestions for a follow up, but no showstoppers