Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitutils: fix checking out submodules #35737

Merged
merged 2 commits into from Jan 5, 2018

Conversation

@tonistiigi
Copy link
Member

commented Dec 7, 2017

Fix issue reported in #32502 (comment)

In addition to adding new command, this also separates the internal clone function so that the test actually tests the commands instead of just validating the commands strings.

@ijc @dnephin @lgarithm

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

gitutils: fix checking out submodules
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

@tonistiigi tonistiigi force-pushed the tonistiigi:fix-git-submodules branch from cb1990f to a602525 Dec 7, 2017

@ijc
ijc approved these changes Dec 8, 2017
Copy link
Contributor

left a comment

LGTM

@dnephin
dnephin approved these changes Dec 8, 2017
Copy link
Member

left a comment

LGTM

@tonistiigi tonistiigi force-pushed the tonistiigi:fix-git-submodules branch from 575ebf4 to a602525 Dec 8, 2017

gitutils: remove checkout directory on error
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@thaJeztah
Copy link
Member

left a comment

LGTM

@yongtang

This comment has been minimized.

Copy link
Member

commented Jan 5, 2018

All tests pass except z, which is a known issue these days. Merging now...

@yongtang yongtang merged commit 50ce546 into moby:master Jan 5, 2018

5 of 6 checks passed

z Jenkins build Docker-PRs-s390x 7566 has failed
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38313 has succeeded
Details
janky Jenkins build Docker-PRs 47051 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7428 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18568 has succeeded
Details
@ryansanford

This comment has been minimized.

Copy link

commented Jan 30, 2018

Any chance this fix will be a new release in the stable channel before March?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.