Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use commit-sha instead of tag for containerd #35770
This patch changes the
This should be considered a temporary workaround; the check
With containerd reaching 1.0, and using SemVer, we can likely
I can add a test for this
- How to verify it
- Description for the changelog
* Fix `docker info` showing "expected: v1.0.0" for containerd [moby/moby#35770](https://github.com/moby/moby/pull/35770)
- A picture of a cute animal (not mandatory but encouraged)
Yes the tag is certainly more readable (although mutable). The reason I chose this solution for now, is that fixing the version-comparison is only half the problem; the CLI would need an update as well, in which case it won't be resolved for older versions (was thinking of comparing by SHA, but printing a user-friendly version).
We need to have a look at it in a wider context though; as I mentioned, with containerd reaching 1.0, there may no longer be a need to do this strict comparison.