New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for referencing images by 'repository:shortid' #35790

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
6 participants
@thaJeztah
Member

thaJeztah commented Dec 13, 2017

The repository:shortid syntax for referencing images is very little used, collides with with tag references can be confused with digest references.

The repository:shortid notation was deprecated in Docker 1.13 through
5fc7159 (#27207), and scheduled for removal in Docker 17.12.

This patch removes the support for this notation.

- Description for the changelog

* Remove support for referencing images through `repository:short-id`. Support for this notation was deprecated in Docker 1.13, and scheduled for removal in Docker 17.12 []()

- A picture of a cute animal (not mandatory but encouraged)

centipede-020

(image source: https://csolsqs.com/centipede/centipede-020.jpg)

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah
Member

thaJeztah commented Dec 13, 2017

@tonistiigi

This comment has been minimized.

Show comment
Hide comment
@tonistiigi

tonistiigi Dec 13, 2017

Member

LGTM

Member

tonistiigi commented Dec 13, 2017

LGTM

@vieux

vieux approved these changes Dec 13, 2017

LGTM

@andrewhsu

This comment has been minimized.

Show comment
Hide comment
@andrewhsu

andrewhsu Dec 14, 2017

Contributor

I see at least 1 failure on experimental and janky:

FAIL: docker_cli_tag_test.go:145: DockerSuite.TestTagTruncationAmbiguity

docker_cli_tag_test.go:152:
    id := inspectField(c, truncatedTag, "Id")
docker_utils_test.go:110:
    c.Assert(err, check.IsNil)
... value *errors.errorString = &errors.errorString{s:"failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n"} ("failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n")
Contributor

andrewhsu commented Dec 14, 2017

I see at least 1 failure on experimental and janky:

FAIL: docker_cli_tag_test.go:145: DockerSuite.TestTagTruncationAmbiguity

docker_cli_tag_test.go:152:
    id := inspectField(c, truncatedTag, "Id")
docker_utils_test.go:110:
    c.Assert(err, check.IsNil)
... value *errors.errorString = &errors.errorString{s:"failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n"} ("failed to inspect notbusybox:1408364a7ed4: \nError: No such object: notbusybox:1408364a7ed4\n")
@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 14, 2017

Member

Darn, I couldn't find a test for this old behaviour, but looks like there was one; fixing

Member

thaJeztah commented Dec 14, 2017

Darn, I couldn't find a test for this old behaviour, but looks like there was one; fixing

@thaJeztah thaJeztah requested review from dnephin and vdemeester as code owners Dec 14, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 14, 2017

Member

Updated, removed the test

Member

thaJeztah commented Dec 14, 2017

Updated, removed the test

Remove support for referencing images by 'repository:shortid'
The `repository:shortid` syntax for referencing images is very little used,
collides with with tag references can be confused with digest references.

The `repository:shortid` notation was deprecated in Docker 1.13 through
5fc7159, and scheduled for removal
in Docker 17.12.

This patch removes the support for this notation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@vdemeester

LGTM 🐸

@thaJeztah thaJeztah merged commit 6796e74 into moby:master Dec 15, 2017

6 checks passed

dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 38411 has succeeded
Details
janky Jenkins build Docker-PRs 47146 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 7529 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 18664 has succeeded
Details
z Jenkins build Docker-PRs-s390x 7357 has succeeded
Details

@thaJeztah thaJeztah deleted the thaJeztah:image-shortid branch Dec 15, 2017

@thaJeztah

This comment has been minimized.

Show comment
Hide comment
@thaJeztah

thaJeztah Dec 15, 2017

Member

💯 ✖️ 5️⃣ 🎉

Member

thaJeztah commented Dec 15, 2017

💯 ✖️ 5️⃣ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment