Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Move kernel_windows to use golang registry functions #36617

Merged
merged 1 commit into from Mar 19, 2018

Conversation

@lowenna
Copy link
Contributor

lowenna commented Mar 16, 2018

Signed-off-by: John Howard jhoward@microsoft.com

@thaJeztah @johnstep Follow-up to #36451 (comment). Moves kernel_windows.go to use the golang registry functions.

Signed-off-by: John Howard <jhoward@microsoft.com>
Copy link
Member

thaJeztah left a comment

LGTM

Copy link
Member

yongtang left a comment

LGTM

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #36617 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #36617      +/-   ##
==========================================
+ Coverage   34.85%   35.08%   +0.23%     
==========================================
  Files         612      612              
  Lines       45445    45435      -10     
==========================================
+ Hits        15838    15940     +102     
+ Misses      27537    27387     -150     
- Partials     2070     2108      +38
Copy link
Member

vdemeester left a comment

LGTM 🐯

@vdemeester vdemeester merged commit 7270b01 into moby:master Mar 19, 2018
8 checks passed
8 checks passed
codecov/patch Coverage not affected when comparing 58de627...29f93c4
Details
codecov/project 35.08% (+0.23%) compared to 58de627
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 39860 has succeeded
Details
janky Jenkins build Docker-PRs 48580 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 9040 has succeeded
Details
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 20075 has succeeded
Details
z Jenkins build Docker-PRs-s390x 8991 has succeeded
Details
@lowenna lowenna deleted the microsoft:jjh/kernel-registry branch Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.