Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Windows layer leak when write fails #36728
Signed-off-by: Darren Stahl email@example.com
- What I did
Fixed a leaked handle that was causing layer deletion to fail when the write of the tar contents failed. This was preventing layer deletion, resulting in a lot of un-removable layers left on disk.
- How I did it
Fixed a leaked handle that occurred when
- How to verify it
Verified locally during stress tests that were causing leaked layers. I've not leaked a layer in days, where before this fix they were leaking regularily.
- Description for the changelog
Fixed a layer leak on Windows.
@@ Coverage Diff @@ ## master #36728 +/- ## ========================================== - Coverage 35.21% 35.19% -0.02% ========================================== Files 614 614 Lines 45645 45645 ========================================== - Hits 16073 16067 -6 - Misses 27441 27447 +6 Partials 2131 2131