New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swagger volume type generation #37060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, golint doesn't like it;
|
😡 |
I would just add it to the exclude list in |
This was broken by bf6a790 Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM (if green)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Codecov Report
@@ Coverage Diff @@
## master #37060 +/- ##
=========================================
Coverage ? 35.09%
=========================================
Files ? 616
Lines ? 45817
Branches ? 0
=========================================
Hits ? 16080
Misses ? 27626
Partials ? 2111 |
This was broken by bf6a790