Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger volume type generation #37060

Merged
merged 1 commit into from May 15, 2018
Merged

Conversation

cpuguy83
Copy link
Member

This was broken by bf6a790

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Oh, golint doesn't like it;

15:17:43 api/types/volume/volume_create.go:12:6:warning: type name will be used as volume.VolumeCreateBody by other packages, and that stutters; consider calling this CreateBody (golint)
15:17:43 api/types/volume/volume_create.go:10:1:warning: comment on exported type VolumeCreateBody should be of the form "VolumeCreateBody ..." (with optional leading article) (golint)
15:17:43 api/types/volume/volume_list.go:14:6:warning: type name will be used as volume.VolumeListOKBody by other packages, and that stutters; consider calling this ListOKBody (golint)
15:17:43 api/types/volume/volume_list.go:12:1:warning: comment on exported type VolumeListOKBody should be of the form "VolumeListOKBody ..." (with optional leading article) (golint)

@cpuguy83
Copy link
Member Author

😡

@dnephin
Copy link
Member

dnephin commented May 14, 2018

I would just add it to the exclude list in hack/validate/gometalinter.json, like we did for container

This was broken by bf6a790

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83
Copy link
Member Author

Fixed.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM (if green)

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link

codecov bot commented May 15, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ab0dccf). Click here to learn what that means.
The diff coverage is 60%.

@@            Coverage Diff            @@
##             master   #37060   +/-   ##
=========================================
  Coverage          ?   35.09%           
=========================================
  Files             ?      616           
  Lines             ?    45817           
  Branches          ?        0           
=========================================
  Hits              ?    16080           
  Misses            ?    27626           
  Partials          ?     2111

@vdemeester vdemeester merged commit bcd86fc into moby:master May 15, 2018
@cpuguy83 cpuguy83 deleted the fix_swagger_gen branch May 15, 2018 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants