Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add api version checking for tests from new feature #37169

Merged
merged 1 commit into from May 30, 2018

Conversation

@AntaresS
Copy link
Contributor

AntaresS commented May 29, 2018

Signed-off-by: Anda Xu anda.xu@docker.com

- What I did

  • add api version condition in service_test.go for new tests introduced with #36396

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@AntaresS AntaresS requested a review from vdemeester as a code owner May 29, 2018
@AntaresS AntaresS force-pushed the AntaresS:add-version-checking branch from 63a841c to 632441c May 29, 2018
Signed-off-by: Anda Xu <anda.xu@docker.com>
@AntaresS AntaresS force-pushed the AntaresS:add-version-checking branch from 632441c to 8ed0fde May 29, 2018
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #37169 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #37169   +/-   ##
=======================================
  Coverage   35.05%   35.05%           
=======================================
  Files         615      615           
  Lines       45828    45828           
=======================================
  Hits        16065    16065           
- Misses      27652    27653    +1     
+ Partials     2111     2110    -1
Copy link
Collaborator

tiborvass left a comment

LGTM

Copy link
Contributor

arm64b left a comment

LGTM

Copy link
Member

vdemeester left a comment

LGTM 🐸

@tiborvass tiborvass merged commit 0a94468 into moby:master May 30, 2018
5 of 6 checks passed
5 of 6 checks passed
windowsRS1 Jenkins build Docker-PRs-WoW-RS1 20965 is running
Details
dco-signed All commits are signed
experimental Jenkins build Docker-PRs-experimental 40845 has succeeded
Details
janky Jenkins build Docker-PRs 49598 has succeeded
Details
powerpc Jenkins build Docker-PRs-powerpc 10028 has succeeded
Details
z Jenkins build Docker-PRs-s390x 9925 has succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.