Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix checkpoint's exiting semantics. #37360
Previously, dockerd would always ask containerd to pass --leave-running
Signed-off-by: Brielle Broder email@example.com
Is this the error?
Actually, there is one more problem. Docker (containerd) has to call "runc checkpoint" with "--empty-ns network" to dump a docker container.
I have a patch which fixes both these issues:
But it depends on containerd changes:
referenced this pull request
Jul 10, 2018
@@ Coverage Diff @@ ## master #37360 +/- ## ========================================== - Coverage 34.95% 34.92% -0.03% ========================================== Files 610 610 Lines 44886 44873 -13 ========================================== - Hits 15690 15673 -17 - Misses 27077 27081 +4 Partials 2119 2119
Jul 26, 2018
5 of 6 checks passed
@tswift242 The default for --leave-running was, and still is, false. Previously, both the default (false) and an explicit set of the flag to false would cause the process to incorrectly continue running after checkpointing because "exit" had not been implemented appropriately, even though the leave-running flag is correctly set.
The leave-running flag's behavior can be seen in: