Fix bindmount autocreate race #37378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolyshkin
reviewed
Jul 2, 2018
volume/mounts/mounts.go
Outdated
| // (Some are auto-created for backwards-compatability) | ||
| // This is checked on the API but setting this here prevents race conditions. | ||
| // where a bind dir existed during validation was removed before reaching the setup code. | ||
| DisableBindmountAutoCreate bool |
There was a problem hiding this comment.
Maybe something simpler, like SkipMountPointCreation or DoNotCreateMountPoint?
There was a problem hiding this comment.
I mean, the name doesn't have to contain BindMount, also it's not clear from yours what is being auto created (a mount point).
There was a problem hiding this comment.
I like it, also makes it more straightforward to just skip setup earlier.
kolyshkin
reviewed
Jul 2, 2018
volume/mounts/mounts.go
Outdated
| if perr.Err != syscall.ENOTDIR { | ||
| return "", errors.Wrapf(err, "error while creating mount source path '%s'", m.Source) | ||
|
|
||
| if !m.DisableBindmountAutoCreate { |
There was a problem hiding this comment.
Maybe
if m.DisableBindmountAutoCreate {
return m.Source, nil
}
When using the mounts API, bind mounts are not supposed to be automatically created. Before this patch there is a race condition between valiating that a bind path exists and then actually setting up the bind mount where the bind path may exist during validation but was removed during mountpooint setup. This adds a field to the mountpoint struct to ensure that binds created over the mounts API are not accidentally created. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_bindmount_src_create_race
branch
from
5db1590
to
1caeb79
Compare
Codecov Report
@@ Coverage Diff @@
## master #37378 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 610
Lines ? 44862
Branches ? 0
=========================================
Hits ? 15682
Misses ? 27065
Partials ? 2115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the mounts API, bind mounts are not supposed to be
automatically created.
Before this patch there is a race condition between validating that a
bind path exists and then actually setting up the bind mount where the
bind path may exist during validation but was removed during mountpooint
setup.
This adds a field to the mountpoint struct to ensure that binds created
over the mounts API are not accidentally created.
Closes #37083