-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildkit: enable net modes and bridge #37620
Conversation
f612659
to
ca016d4
Compare
"github.com/moby/buildkit/util/tracing" | ||
"github.com/pkg/errors" | ||
"golang.org/x/sync/errgroup" | ||
grpcmetadata "google.golang.org/grpc/metadata" | ||
) | ||
|
||
func init() { | ||
llbsolver.AllowNetworkHostUnstable = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a temporary variable that needs to be set globally because buildkit by default forbids host network entitlement on daemon level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will give the patch a try for better understanding.
Codecov Report
@@ Coverage Diff @@
## master #37620 +/- ##
=========================================
Coverage ? 35.16%
=========================================
Files ? 611
Lines ? 45817
Branches ? 0
=========================================
Hits ? 16112
Misses ? 27485
Partials ? 2220 |
Forgot to add |
ad04a1c
to
fcd1f8e
Compare
This test is failing on all CI, so may be related;
|
vendor.conf
Outdated
@@ -26,7 +26,7 @@ github.com/imdario/mergo v0.3.6 | |||
golang.org/x/sync 1d60e4601c6fd243af51cc01ddf169918a5407ca | |||
|
|||
# buildkit | |||
github.com/moby/buildkit e57eed420c7573ae44875be98fa877175b4677a1 | |||
github.com/moby/buildkit 95e0348f571a0e500a9b6911992c92f877b44ff1 git://github.com/tonistiigi/buildkit.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moby/buildkit#560 was merged; so this can likely be "un-forked"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thaJeztah yes, I'll update as soon I fixed the failure hopefully with @abhi's help
fcd1f8e
to
1dca148
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
1dca148
to
4a40f92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes the default network used by buildkit to libnetwork bridge and enables
--network=host
and--network=none
. Frontends have the capability to set networking modes per-command.depends on moby/buildkit#560
@fcrisciani @abhi
EDIT: Related to moby/buildkit#583 and #37676