buildkit: enable net modes and bridge #37620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
buildkit-net-modes
branch
from
f612659
to
ca016d4
Compare
tonistiigi
commented
Aug 10, 2018
| "github.com/moby/buildkit/util/tracing" | ||
| "github.com/pkg/errors" | ||
| "golang.org/x/sync/errgroup" | ||
| grpcmetadata "google.golang.org/grpc/metadata" | ||
| ) | ||
|
|
||
| func init() { | ||
| llbsolver.AllowNetworkHostUnstable = true |
There was a problem hiding this comment.
This is a temporary variable that needs to be set globally because buildkit by default forbids host network entitlement on daemon level.
abhi
approved these changes
Aug 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #37620 +/- ##
=========================================
Coverage ? 35.16%
=========================================
Files ? 611
Lines ? 45817
Branches ? 0
=========================================
Hits ? 16112
Misses ? 27485
Partials ? 2220 |
|
Forgot to add |
tonistiigi
force-pushed
the
buildkit-net-modes
branch
from
ad04a1c
to
fcd1f8e
Compare
tiborvass
added
status/2-code-review
rebuild/janky
and removed
status/1-design-review
labels
|
This test is failing on all CI, so may be related; |
thaJeztah
requested changes
Aug 17, 2018
vendor.conf
Outdated
| @@ -26,7 +26,7 @@ github.com/imdario/mergo v0.3.6 | |||
| golang.org/x/sync 1d60e4601c6fd243af51cc01ddf169918a5407ca | |||
|
|
|||
| # buildkit | |||
| github.com/moby/buildkit e57eed420c7573ae44875be98fa877175b4677a1 | |||
| github.com/moby/buildkit 95e0348f571a0e500a9b6911992c92f877b44ff1 git://github.com/tonistiigi/buildkit.git | |||
There was a problem hiding this comment.
moby/buildkit#560 was merged; so this can likely be "un-forked"
There was a problem hiding this comment.
@thaJeztah yes, I'll update as soon I fixed the failure hopefully with @abhi's help
thaJeztah
added
the
status/failing-ci
tiborvass
force-pushed
the
buildkit-net-modes
branch
from
fcd1f8e
to
1dca148
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
buildkit-net-modes
branch
from
1dca148
to
4a40f92
Compare
abhi
approved these changes
Aug 20, 2018
thaJeztah
removed
the
status/failing-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default network used by buildkit to libnetwork bridge and enables
--network=hostand--network=none. Frontends have the capability to set networking modes per-command.depends on moby/buildkit#560
@fcrisciani @abhi
EDIT: Related to moby/buildkit#583 and #37676