-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'docker-' prefix for containerd and runc binaries #37907
Remove 'docker-' prefix for containerd and runc binaries #37907
Conversation
d077cbb
to
a417216
Compare
Codecov Report
@@ Coverage Diff @@
## master #37907 +/- ##
==========================================
- Coverage 36.1% 36.09% -0.02%
==========================================
Files 610 610
Lines 45115 45121 +6
==========================================
- Hits 16291 16288 -3
- Misses 26584 26593 +9
Partials 2240 2240 |
a417216
to
d62e211
Compare
This allows to run the daemon in environments that have upstream containerd installed. Signed-off-by: Tibor Vass <tibor@docker.com>
d62e211
to
34eede0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👼
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm wondering this might cause packaging issues. |
ping @seemethere ^^ |
|
This is a very bad idea -- Docker has always been stuck on an older version of There is no workaround for this change either! Speaking on the openSUSE side of things, we will carry a revert of this patch.
This is not a good practice when packaging (and distributions won't accept such packages), not to mention that attempting to install such packages on most distributions will result in warnings due to file conflicts between packages. |
Yes, it is. Another issue: When I use my own default containerd to start docker, once I kill containerd, then restart dockerd, dockerd will start his own contanerd, then the old containerd-shim is not stopped, and another containerd-shim is started, there are two containerd-shim for one container. |
This allows to run the daemon in environments that have upstream containerd installed.
Signed-off-by: Tibor Vass tibor@docker.com