New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup jobs #3800

Merged
merged 3 commits into from Jan 31, 2014

Conversation

Projects
None yet
3 participants
@vieux
Collaborator

vieux commented Jan 28, 2014

ping @shykes

@vieux vieux referenced this pull request Jan 29, 2014

Merged

Move api package #3827

@shykes

This comment has been minimized.

Show comment
Hide comment
@shykes

shykes Jan 31, 2014

Collaborator

LGTM (pending rebase)

Collaborator

shykes commented Jan 31, 2014

LGTM (pending rebase)

vieux added some commits Jan 25, 2014

Remove api_params.go
Docker-DCO-1.1-Signed-off-by: Victor Vieux <victor.vieux@docker.com> (github: vieux)
job.error\* now return engine.StatusErr
Docker-DCO-1.1-Signed-off-by: Victor Vieux <victor.vieux@docker.com> (github: vieux)
add setSubEnv and getSubEnv
Docker-DCO-1.1-Signed-off-by: Victor Vieux <victor.vieux@docker.com> (github: vieux)
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jan 31, 2014

Collaborator

@unclejack could you please merge this when you wake up ? (tested on both btrfs et aufs)

Collaborator

vieux commented Jan 31, 2014

@unclejack could you please merge this when you wake up ? (tested on both btrfs et aufs)

@unclejack

This comment has been minimized.

Show comment
Hide comment
@unclejack

unclejack Jan 31, 2014

Contributor

LGTM

Contributor

unclejack commented Jan 31, 2014

LGTM

unclejack added a commit that referenced this pull request Jan 31, 2014

@unclejack unclejack merged commit 35ef0d3 into moby:master Jan 31, 2014

1 check passed

default The Travis CI build passed
Details
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jan 31, 2014

Collaborator

Thank you Sir!

On Fri, Jan 31, 2014 at 6:55 AM, unclejack notifications@github.com wrote:

Merged #3800 #3800.

Reply to this email directly or view it on GitHubhttps://github.com/moby/moby/pull/3800
.

Victor VIEUX
http://vvieux.com

Collaborator

vieux commented Jan 31, 2014

Thank you Sir!

On Fri, Jan 31, 2014 at 6:55 AM, unclejack notifications@github.com wrote:

Merged #3800 #3800.

Reply to this email directly or view it on GitHubhttps://github.com/moby/moby/pull/3800
.

Victor VIEUX
http://vvieux.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment