/moby

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move port mapper out of core and into network drivers #3819

Merged
merged 2 commits into from Jan 29, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@crosbymichael @vieux @unclejack
@crosbymichael
Contributor

crosbymichael commented Jan 29, 2014 

=== RUN TestSetIptablesChain
--- PASS: TestSetIptablesChain (0.00 seconds)
=== RUN TestMapPorts
--- PASS: TestMapPorts (0.00 seconds)
=== RUN TestGetUDPKey
--- PASS: TestGetUDPKey (0.00 seconds)
=== RUN TestGetTCPKey
--- PASS: TestGetTCPKey (0.00 seconds)
=== RUN TestGetUDPIPAndPort
--- PASS: TestGetUDPIPAndPort (0.00 seconds)
PASS
coverage: 80.4% of statements
ok      github.com/dotcloud/docker/networkdriver/portmapper     0.005s

crosbymichael added some commits Jan 28, 2014

@crosbymichael
Initial move of port mapper code into sub pkg 
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
99756ef
@crosbymichael
Move port mapper tests out of core and into portmapper 
Docker-DCO-1.1-Signed-off-by: Michael Crosby <michael@crosbymichael.com> (github: crosbymichael)
b3b12f0
@vieux

This comment has been minimized.

Show comment
Hide comment
@vieux

vieux Jan 29, 2014

Collaborator

LGTM
Collaborator

vieux commented Jan 29, 2014

LGTM
@unclejack

This comment has been minimized.

Show comment
Hide comment
@unclejack

unclejack Jan 29, 2014

Contributor

LGTM
Contributor

unclejack commented Jan 29, 2014

LGTM

crosbymichael added a commit that referenced this pull request Jan 29, 2014

@crosbymichael
Merge pull request #3819 from crosbymichael/move-port-mapper 
Move port mapper out of core and into network drivers
6fdc543

@crosbymichael crosbymichael merged commit 6fdc543 into moby:master Jan 29, 2014
1 check passed

1 check passed

default The Travis CI build passed
Details

@crosbymichael crosbymichael deleted the crosbymichael:move-port-mapper branch Jan 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment