Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to attach swarm overlay networks by prefix id #38699

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@andrey-ko
Copy link
Contributor

commented Feb 9, 2019

Fix for swarm overlay networks, to allow to use network prefix id for attaching
steps to reproduce (on swarm manager):

docker@master-ubuntu:~$ docker network create -d overlay --subnet 10.90.0.0/16 --attachable test
2pxynaf6x6ns73osfh3djihp5
docker@master-ubuntu:~$ docker network ls
NETWORK ID          NAME                                                              DRIVER              SCOPE
286e5591d39a        bridge                                                            bridge              local
14260d5e8dd5        docker_gwbridge                                                   bridge              local
f15db39321be        host                                                              host                local
jr107lomespv        ingress                                                           overlay             swarm
cad86ad056ce        none                                                              null                local
2pxynaf6x6ns        test                                                                                  swarm
docker@master-ubuntu:~$ docker run --rm -it --network 2pxynaf6x6ns centos:7
docker: Error response from daemon: Could not attach to network 2pxynaf6x6ns: rpc error: code = NotFound desc = network 2pxynaf6x6ns not found.
docker@master-ubuntu:~$ docker run --rm -it --network 2pxynaf6x6ns73osfh3djihp5 centos:7
[root@69322b8f0cc4 /]# exit
exit
docker@master-ubuntu:~$ docker run --rm -it --network test centos:7
[root@db369d3829af /]# exit
exit
Allow attach swarm overlay networks by prefix id
Signed-off-by: Andrey Kolomentsev <andrey.kolomentsev@docker.com>
@thaJeztah
Copy link
Member

left a comment

Thanks! I want to have a close look at this change, because there's some special logic in this area and changing things caused some things to break in the past.

I'll try to have a look asap, but leaving a "request changes" review for now, so that it doesn't get merged before that 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.