Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement exec kill API #38704
- What I did
I implemented a feature to kill exec instance.
- How I did it
I added an API endpoint for the action and a method to call it in the client, then implemented an exec action in the daemon.
- How to verify it
- Description for the changelog
Add exec kill feature with API endpoint and a client method
- A picture of a cute animal (not mandatory but encouraged)
Please sign your commits following these rules:
$ git clone -b "35703-exec-kill" firstname.lastname@example.org:dtaniwaki/moby.git somewhere $ cd somewhere $ git commit --amend -s --no-edit $ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
@@ Coverage Diff @@ ## master #38704 +/- ## ========================================== + Coverage 36.53% 36.57% +0.03% ========================================== Files 610 610 Lines 45395 45410 +15 ========================================== + Hits 16584 16607 +23 + Misses 26517 26506 -11 - Partials 2294 2297 +3
Hmm... It's weird. The test passes in my local and the error in CI
should not happen.