Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Update createSpec to use errdefs #38770
Signed-off-by: Drew Erny email@example.com
- What I did
Updates the createSpec method, for both Windows and Linux systems, to return all errors in terms of errdefs. Makes easy changes in dependencies of those methods as well, if bringing them to use all errdefs errors was trivial. Includes comments annotating why each errdef type was chosen for each particular error.
- How I did it
Carefully step through createSpec and its dependencies, and wrapped each error in an
- How to verify it
You sort of have to review it by hand. This function is really bad in terms of complexity, so a comprehensive test case to cover it would be prohibitively difficult to write.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
cpuguy83 left a comment •
Thanks for following up.
Some general comments.
@@ Coverage Diff @@ ## master #38770 +/- ## ========================================= Coverage ? 36.42% ========================================= Files ? 613 Lines ? 45847 Branches ? 0 ========================================= Hits ? 16700 Misses ? 26852 Partials ? 2295