Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the error message 'Cannot locate specified Dockerfile' to be more helpful. #38778

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@eashi
Copy link

eashi commented Feb 22, 2019

- What I did
I have been troubleshooting why my docker build command wasn't working, I was getting the error "Cannot locate specified Dockerfile" Add possible reason why this error would happen.

- How I did it
I just changed the error message.

- How to verify it

- Description for the changelog
Change language of error message in detect.go and corresponding test file internals_test.go

- A picture of a cute animal (not mandatory but encouraged)

Change the error message to be more helpful
Add possible reason why the error 'Cannot locate specified Dockerfile' would happen.

Signed-off-by: Emad Alashi <emad.ashi@gmail.com>
@tonistiigi

This comment has been minimized.

Copy link
Member

tonistiigi commented Mar 21, 2019

This is weird. You should be able to add Dockerfile to .dockerignore. This works in buildkit for sure, and I think it should work in legacy as well. What's the sample case?

@eashi

This comment has been minimized.

Copy link
Author

eashi commented Mar 25, 2019

Apologies, I tried to reproduce my issue and I couldn't, obviously I was doing something wrong. I will close this PR. 😅

@eashi eashi closed this Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.